Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9385#issuecomment-156238962
I'm sorry, I don't see where this `expand()` function you are talking about
is, or why it should not use `semanticEquals`. The whole point of
`semanticEquals` is "are these two attributes referring to the same data, and
in many cases this is actually what you want instead of structural equality
(structural equality matters, for example, when you are checking to see if a
tree has reached fixed point. otherwise we could not use rules to make changes
to Attributes that are cosmetic in nature).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
