Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/9661#discussion_r44727149
--- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
@@ -154,15 +155,17 @@ private[spark] class HighlyCompressedMapStatus
private (
override def writeExternal(out: ObjectOutput): Unit =
Utils.tryOrIOException {
loc.writeExternal(out)
- emptyBlocks.writeExternal(out)
+ markedBlocks.writeExternal(out)
--- End diff --
given the immutability of them, this should be unnecessary, right? We can
just call it once when we construct it? (I totally agree we need to call it at
least once, but I think its more appropriate in the other spot.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
