Github user xguo27 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9603#discussion_r44728655
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -506,6 +506,7 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
         val (sched, ts) = SparkContext.createTaskScheduler(this, master)
         _schedulerBackend = sched
         _taskScheduler = ts
    +    logDebug("Starting DAGScheduler")
    --- End diff --
    
    Hi Jacek:
    
    My only concern with putting log in DAGScheduler's constructor is that the 
logger might not have been initialized when constructor is called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to