Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9060#discussion_r44764961 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala --- @@ -513,6 +515,41 @@ class ParquetIOSuite extends QueryTest with ParquetTest with SharedSQLContext { } } + test("SPARK-11044 Parquet writer version fixed as version1 ") { + + // For dictionary encoding, Parquet changes the encoding types according to its writer version + // So, this test checks the encoding types in order to ensure that the file is written with + // writer version2. + withTempPath { dir => + val clonedConf = new Configuration(hadoopConfiguration) + try { + --- End diff -- Nit: Remove this empty line.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org