Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9272#discussion_r44814575
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala ---
@@ -150,6 +152,21 @@ private[hive] class ClientWrapper(
val original = Thread.currentThread().getContextClassLoader
// Switch to the initClassLoader.
Thread.currentThread().setContextClassLoader(initClassLoader)
+
+ val sparkConf = new SparkConf
--- End diff --
@yolandagao Thanks for the explanation. Can you add comments to your code
(including why we need to put those confs to sysProps and why we need to create
a new SparkConf at here)? Basically, we need to document the flow of how these
confs get propagated. Otherwise, it is not obvious why we need to do this
change. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
