Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9712#discussion_r44871929
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala
---
@@ -68,7 +117,36 @@ class RowEncoderSuite extends SparkFunSuite {
.add("structOfArray", new StructType().add("array", arrayOfString))
.add("structOfMap", new StructType().add("map", mapOfString))
.add("structOfArrayAndMap",
- new StructType().add("array", arrayOfString).add("map",
mapOfString)))
+ new StructType().add("array", arrayOfString).add("map",
mapOfString))
+ .add("structOfUDT", structOfUDT))
+
+ test(s"encode/decode: arrayOfUDT") {
+ val schema = new StructType()
+ .add("arrayOfUDT", arrayOfUDT)
+
+ val encoder = RowEncoder(schema)
+
+ val input: Row = Row(Seq(new ExamplePoint(0.1, 0.2), new
ExamplePoint(0.3, 0.4)))
+ val row = encoder.toRow(input)
+ val convertedBack = encoder.fromRow(row)
+ assert(input.getSeq[ExamplePoint](0) ==
convertedBack.getSeq[ExamplePoint](0))
+ }
+
+ test(s"encode/decode: Product") {
+ val schema = new StructType()
+ .add("structAsProduct",
+ new StructType()
+ .add("int", IntegerType)
+ .add("string", StringType)
+ .add("double", DoubleType))
+
+ val encoder = RowEncoder(schema)
+
+ val input: Row = Row((100, "test", 0.123))
--- End diff --
If one of the input parameter is `Tuple2`, then we need to use the encoder
to decode a catalyst value to external value, i.e. decode an `InternalRow`
object to `Tuple2` object. I think this is hard for a `RowEncoder`(your change
only makes it possible to encode a `Product` into `InternalRow`, but not vice
versa), we should use `ProductEncoder` for this case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
