Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/9546#issuecomment-156846877
  
    I think that this has caused the  
"org.apache.spark.scheduler.EventLoggingListenerSuite.End-to-end event logging" 
test to become flaky in Jenkins.
    
    I believe that this patch may have changed the behavior of the listener bus 
during shutdown. According to the `stop()` method's Scaladoc:
    
    ```
      /**
       * Stop the listener bus. It will wait until the queued events have been 
processed, but drop the
       * new events after stopping.
       */
    ```
    
    It looks like this patch just changes things so that we halt immediately 
once the `stopped` flag has been set rather than waiting for the queue to drain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to