Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9367#discussion_r44880126
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala ---
@@ -119,5 +124,47 @@ class TaskResultGetterSuite extends SparkFunSuite with
BeforeAndAfter with Local
// Make sure two tasks were run (one failed one, and a second retried
one).
assert(scheduler.nextTaskId.get() === 2)
}
+
+ // SPARK-11195
+ // Make sure we are using the context classloader when deserializing
failed TaskResults instead of
+ // the Spark classloader.
+ test("failed task deserialized with the correct classloader") {
--- End diff --
Can we add comments to outline how this fix is tested?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
