Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9674#discussion_r44983864
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -166,6 +173,34 @@ class Pipeline(override val uid: String) extends
Estimator[PipelineModel] {
"Cannot have duplicate components in a pipeline.")
theStages.foldLeft(schema)((cur, stage) => stage.transformSchema(cur))
}
+
+ override def write: Writer = new PipelineWriter(this)
+}
+
+object Pipeline extends Readable[Pipeline] {
+
+ override def read: Reader[Pipeline] = new PipelineReader
+
+ override def load(path: String): Pipeline = read.load(path)
+}
+
+private[ml] class PipelineWriter(instance: Pipeline) extends Writer {
+
+ PipelineSharedWriter.validateStages(instance.getStages)
--- End diff --
Should users be able to save an incomplete pipeline? For example, I could
make a template pipeline, send it to other users, and they only need to fill in
some required params like inputCol after they load it back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
