Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9674#issuecomment-157179166 One suggestion is to merge `PipelineShardWriter` and `PipelineSharedReader` into a single object under `object Pipeline`, e.g., called `SharedReadWrite`. Then move `PipelineReader`, `PipelineWriter` to `object Pipeline`, and `PipelineModelReader` and `PipelineModelWriter` to `object PipelineModel`. The main purpose it to not pollute the package space in Java. Otherwise, they are all visible under `org.apache.spark.ml` in Java.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org