Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9752#discussion_r45144395
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -422,6 +422,37 @@ private[spark] class MesosClusterScheduler(
desc.schedulerProperties.get("spark.cores.max").map { v =>
options ++= Seq("--total-executor-cores", v)
}
+
+ /**
+ * The properties to pass along from Spark Submit to the Mesos
Scheduler.
+ *
http://spark.apache.org/docs/1.5.1/configuration.html#available-properties
+ */
+ val propertiesToPropagate = Set(
+ "spark.driver.extraClassPath",
--- End diff --
I see, the idea is that we pass all configuration to run the spark job as
if you're running it locally to the scheduler to forward, so when it runs
somewhere in the cluster it should have the same configurations.
I think the right fix is to include everything and allow overrides like the
ones you mentioned. I need to look into more if what other flags we need to
consider, @andrewor14 do you any other flags we need to capture?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
