Github user dtolpin commented on the pull request:
https://github.com/apache/spark/pull/9775#issuecomment-157806025
I don't see how I can make a meaningful unit test for this bug,
unfortunately. That would require that I use a time-based window with
reduceByKeyAndWindow, and fixture provided with unittests for python streaming
do not support this.
However, this change just changes checking a constant (which is
meaningless) for trueness to checking a parameter. I understand that everything
must be covered by unit tests, but the way the code is written it is an
objective which is very difficult to achieve. Modifying the code so that it is
unit-testable is a major rewrite, which won't have time to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
