Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9182#issuecomment-157813169
OK, this is what I've done
1. AM doesn't propagate app/attempt IDs via system properties. It still
sets them for other things to use, including `SparkContext`, but its not used
to set up the `YarnClusterSchedulerBackend`.
1. `YarnSchedulerBackend` uses its `appId` and `appAttemptId` fields to
generate the string values for the `applicationAttemptId()` and
`applicationId()`; the subclasses have had those cut.
1. `YarnSchedulerBackend.appId` is now a protected option; its referenced
in `YarnClientSchedulerBackend`, references now using `isDefined` and `get`
where appropriate.
This simplifies the two backend subclasses, as their parent does more. I'm
not sure that the direct accessing of the `appId` is particularly elegant though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
