Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8883#discussion_r45264025
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala ---
@@ -190,7 +190,6 @@ abstract class PredictionModel[FeaturesType, M <:
PredictionModel[FeaturesType,
/**
* Predict label for the given features.
- * This internal method is used to implement [[transform()]] and output
[[predictionCol]].
*/
- protected def predict(features: FeaturesType): Double
+ def predict(features: FeaturesType): Double
--- End diff --
This breaks source compatibility but not binary compatibility. It is
probably safe if we don't assume that users subclass our estimators.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
