Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9797#discussion_r45389631
--- Diff: ec2/spark_ec2.py ---
@@ -591,11 +591,15 @@ def launch_cluster(conn, opts, cluster_name):
# AWS ignores the AMI-specified block device mapping for M3 (see
SPARK-3342).
if opts.instance_type.startswith('m3.'):
+ if sys.version_info[0] >= 3:
+ letters = string.ascii_letters
--- End diff --
Actually, it looks like Python 2.6 also has `string.ascii_letters`:
https://docs.python.org/2.6/library/string.html#string.ascii_letters
Why not just use that for both Python 2.x and 3.x so that we don't need
this conditional check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
