Github user darabos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1329#discussion_r14665377
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -768,6 +768,10 @@ class DAGScheduler(
               abortStage(stage, "Task not serializable: " + e.toString)
               runningStages -= stage
               return
    +        case e: Throwable => // Other exceptions, such as 
IllegalArgumentException from Kryo.
    --- End diff --
    
    I suspect you are testing this on 2.10. Looks like a change in 2.11:
    
    
https://github.com/scala/scala/commit/64603653f82082431941cb29ad317b669822f28e#diff-ff42321ce198f97308744271b7e17c76
    
    I think their argument applies to Spark too. Sounds like it is not safe to 
try and recover from StackOverflowError.
    
    Thanks for the comments! I'll update the pull request in a moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to