Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9843#discussion_r45905446
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala ---
@@ -218,7 +218,7 @@ private object IDFModel {
newValues(k) = values(k) * idf(indices(k))
k += 1
}
- Vectors.sparse(n, indices, newValues)
+ Vectors.sparse(n, indices, newValues).toSparse
--- End diff --
@dbtsai what do you think about it as it looks like you made the test?
https://github.com/apache/spark/commit/b5d17ef10e2509d9886c660945449a89750c8116
Seems like it should be valid for sparse vectors to ignore 0 entries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
