Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9979#discussion_r45926725
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -86,7 +120,10 @@ private[hive] object IsolatedClientLoader {
tempDir.listFiles().map(_.toURI.toURL)
}
- private def resolvedVersions = new
scala.collection.mutable.HashMap[HiveVersion, Seq[URL]]
+ // A map from a given pair of HiveVersion and Hadoop version to jar
files.
+ // It is only used by forVersion.
+ private val resolvedVersions =
+ new scala.collection.mutable.HashMap[(HiveVersion, String), Seq[URL]]
--- End diff --
@marmbrus This should be a `val`, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
