Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9858#discussion_r46002572
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
    @@ -488,6 +488,12 @@ private[sql] case class EnsureRequirements(sqlContext: 
SQLContext) extends Rule[
       }
     
       def apply(plan: SparkPlan): SparkPlan = plan.transformUp {
    +    case operator @ Exchange(partitioning, child, _) =>
    +      child.children match {
    +        case Exchange(childPartitioning, baseChild, _)::Nil =>
    --- End diff --
    
    Hey, so I know that I said to add the logic here, but now I'm realizing its 
kind of odd to add it into the plan and then remove it.  Why don't we just 
never add it?  Maybe this logic should go in SparkStrategies?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to