Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10009#discussion_r46015947
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -448,18 +438,12 @@ class CodeGenContext {
// 2. Less code.
// Currently, we will do this for all non-leaf only expression trees
(i.e. expr trees with
// at least two nodes) as the cost of doing it is expected to be low.
-
- // Maintain the loaded value and isNull as member variables. This is
necessary if the codegen
- // function is split across multiple functions.
- // TODO: maintaining this as a local variable probably allows the
compiler to do better
- // optimizations.
- addMutableState("boolean", isLoaded, s"$isLoaded = false;")
addMutableState("boolean", isNull, s"$isNull = false;")
addMutableState(javaType(expr.dataType), value,
s"$value = ${defaultValue(expr.dataType)};")
- subExprIsLoadedVariables += isLoaded
- val state = SubExprEliminationState(isLoaded, code, fnName)
+ subExprResetVariables += s"${fnName}($INPUT_ROW);"
--- End diff --
nit: `$fnName($INPUT_ROW)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
