Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9991#issuecomment-160714495
> Sorry, I don't follow. SparkListenerApplicationEnd is posted by
SparkContext.stop, which is the same place where you're adding the hook to
clean up the listener. So it should behave exactly the same way, no?
It's a bit different because the location of `postApplicationEnd()` is at
the beginning of `stop`?
Not related to this issue: I just noticed the location in
`postApplicationEnd()` may be not in the correct place. There is a race
condition that after `postApplicationEnd()`, some task/job events will still be
put into the listener bus. Is it safe to move `postApplicationEnd()` to the
bottom of `stop`? Then I think it's exactly the same way that adding a hook.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
