Github user suyanNone commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9992#discussion_r46235437
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
    @@ -228,6 +228,7 @@ private[spark] class ApplicationMaster(
       }
     
       private def sparkContextStopped(sc: SparkContext) = {
    +    sc.requestTotalExecutors(0, 0, Map.empty)
    --- End diff --
    
    right... I am little mix with yarnScheduler and yarnSchedulerBackend 
class...
    the stop order was:
    YarnClusterScheduler.stop
     ->TaskSchedulerImpl.stop -> CoarsedGrainSchedulerbackend.stop -> asyn: 
stopExecutors
     -> ApplicationMaster.sparkContextStopped(sc)
     
    may be it is good way to override stop() in YarnSchedulerBackend. 
    ```
    YarnSchedulerBackend.stop {
      doRequestTotalExecutors() //this is a askWithRetry...
      super.stop
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to