Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10061#discussion_r46245537
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -1263,6 +1264,8 @@ object SQLContext {
        */
       @transient private val instantiatedContext = new 
AtomicReference[SQLContext]()
     
    +  @transient private val sqlListener = new AtomicReference[SQLListener]()
    --- End diff --
    
    Just to make sure that it's not overlooked, please see my comment on the 
other PRs regarding whether this needs to actually hold a `SQLListener` 
instance or whether it can simply be an `AtomicBoolean`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to