Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/9565#discussion_r46292490
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -1047,6 +391,11 @@ case class ScalaUDF(
"""
}
- private[this] val converter =
CatalystTypeConverters.createToCatalystConverter(dataType)
- override def eval(input: InternalRow): Any = converter(f(input))
+ lazy val outputEncoder: ExpressionEncoder[Row] =
+ RowEncoder(StructType(StructField("_c0", dataType) :: Nil))
+
+ override def eval(input: InternalRow): Any = {
+ val projected = InternalRow.fromSeq(children.map(_.eval(input)))
+
outputEncoder.toRow(Row(f(projected))).copy().asInstanceOf[InternalRow].get(0,
dataType)
--- End diff --
Because `toRow` are to return the same actual `InternalRow` object in
`ExpressionEncoder`. We need to copy the result. Otherwise, as I tried, the
results will be incorrect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
