Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8880#discussion_r46488157
  
    --- Diff: docs/configuration.md ---
    @@ -477,6 +477,64 @@ Apart from these, the following properties are also 
available, and may be useful
         <code>spark.io.compression.codec</code>.
       </td>
     </tr>
    +<tr>
    +  <td><code>spark.shuffle.chimera.crypto.cipher.suite</code></td>
    +  <td>AES/CTR/NoPadding</td>
    +  <td>
    +    Cipher suite for crypto codec.
    +  </td>
    +</tr>
    +<tr>
    +  <td><code>spark.shuffle.chimera.crypto.codec.classes</code></td>
    +  <td></td>
    +  <td>
    +    The prefix for a given crypto codec, contains a comma-separated
    +    list of implementation classes for a given crypto codec (eg 
AES/CTR/NoPadding).
    +    The first implementation will be used if available, others are 
fallbacks.
    +  </td>
    +</tr>
    +<tr>
    +  <td><code>spark.shuffle.chimera.crypto.jce.provider</code></td>
    +  <td></td>
    +  <td>
    +    The JCE provider name used in CryptoCodec.
    --- End diff --
    
    Users don't know what "CryptoCodec" is. Why would they configure this? 
That's what the documentation should say.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to