Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10127#discussion_r46604122
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobGenerator.scala
 ---
    @@ -220,7 +220,8 @@ class JobGenerator(jobScheduler: JobScheduler) extends 
Logging {
         logInfo("Batches pending processing (" + pendingTimes.size + " 
batches): " +
           pendingTimes.mkString(", "))
         // Reschedule jobs for these times
    -    val timesToReschedule = (pendingTimes ++ 
downTimes).distinct.sorted(Time.ordering)
    +    val timesToReschedule = (pendingTimes ++ downTimes).filter { _ != 
restartTime }
    +      .distinct.sorted(Time.ordering)
    --- End diff --
    
    Explained offline: 
    
    The restart time is always checkpointTime+1 (assuming batch duration = 1). 
However, pending times can already have batches >= checkpointTime+1. This can 
cause `timesToReschedule` to have batches >= checkpointTime+1, which will be 
explicitly submitted, and then resubmitted through the timer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to