Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9358#discussion_r46657310
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/Encoder.scala
 ---
    @@ -37,3 +37,120 @@ trait Encoder[T] extends Serializable {
       /** A ClassTag that can be used to construct and Array to contain a 
collection of `T`. */
       def clsTag: ClassTag[T]
     }
    +
    +object Encoder {
    +  import scala.reflect.runtime.universe._
    +
    +  def BOOLEAN: Encoder[java.lang.Boolean] = ExpressionEncoder(flat = true)
    +  def BYTE: Encoder[java.lang.Byte] = ExpressionEncoder(flat = true)
    +  def SHORT: Encoder[java.lang.Short] = ExpressionEncoder(flat = true)
    +  def INT: Encoder[java.lang.Integer] = ExpressionEncoder(flat = true)
    +  def LONG: Encoder[java.lang.Long] = ExpressionEncoder(flat = true)
    +  def FLOAT: Encoder[java.lang.Float] = ExpressionEncoder(flat = true)
    +  def DOUBLE: Encoder[java.lang.Double] = ExpressionEncoder(flat = true)
    +  def STRING: Encoder[java.lang.String] = ExpressionEncoder(flat = true)
    --- End diff --
    
    @cloud-fan Could you share me your idea why we do not add the other basic 
types like DecimalType, DateType and TimestampType? Thank you! 
    
    DecimalType -> java.math.BigDecimal
    DateType -> java.sql.Date
    TimestampType -> java.sql.Timestamp


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to