Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46700913
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -610,11 +701,38 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
* directory, `None` is returned, indicating that there isn't an event
log at that location.
*/
private def getModificationTime(fsEntry: FileStatus): Option[Long] = {
+ getStatusAttribute(fsEntry, (f => f.getModificationTime()))
+ }
+
+ /**
+ * Get the size of the log, or `None` if there isn't one in the child
+ * directory of a legacy log entry
+ * @param fsEntry file status of a path
+ * @return the log size
+ */
+ private def getLogSize(fsEntry: FileStatus): Option[Long] = {
+ if (isLegacyLogDirectory(fsEntry)) None else Some(fsEntry.getLen)
+// getStatusAttribute(fsEntry, (f => f.getLen()))
--- End diff --
-gone to the simpler version and reverted the generic "get status
attribute" back into `getModificationTime()` for a smaller diff and simpler
code. Its unlikely that people will be running new legacy-log applications, and
if they are, well, no incremental playback for them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
