Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9963#discussion_r46748106
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,9 @@ private[spark] abstract class YarnSchedulerBackend(
private implicit val askTimeout = RpcUtils.askRpcTimeout(sc.conf)
+ // Flag to specify whether AM is registered or not.
+ @volatile private var isAmRegistered = false
--- End diff --
The name of this variable is misleading; it sounds like it's tracking
whether there is an AM registered, but it's tracking whether an AM has ever
been registered, even if currently there's no AM.
So the name should be something like "shouldResetOnAmRegistration" or
something less verbose... which raises the question, could you just reset also
on the first registration? What ill side-effects could that cause?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
