Github user codingjaguar commented on the pull request:
https://github.com/apache/spark/pull/10163#issuecomment-162588751
Thanks for giving feedback! We think it would be nice to support all
commutative operators in `Expression.semanticEquals`, but it doesn't seem to
directly help cache matching. `LogicalPlan.sameResult` doesn't use
`Expression.semanticEquals`, instead it simply checked `cleanRight.cleanArgs ==
cleanLeft.cleanArgs`. Here we refactored the code by moving
`equivalentConditions` to `PredicateHelper.equivalentPredicates`, so that
people can also use this feature in other scenarios.
We didn't support other communicative operators because they rarely show up
in WHERE clause as root expression. For example, `WHERE Max(a.id, 5)` is not a
meaningful sql statement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
