Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r46997515
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -56,12 +55,16 @@ abstract class RuleExecutor[TreeType <: TreeNode[_]]
extends Logging {
case class FixedPoint(maxIterations: Int) extends Strategy
/** A batch of rules. */
- protected case class Batch(name: String, strategy: Strategy, rules:
Rule[TreeType]*)
+ case class Batch[TreeType <: TreeNode[_]]
--- End diff --
I'd probably just make these top level classes if we are going to pull them
out. There is not a lot of stuff in the `rules` package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
