Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r47030172
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -131,7 +131,42 @@ class Word2VecSuite extends SparkFunSuite with
MLlibTestSparkContext {
expectedSimilarity.zip(similarity).map {
case (expected, actual) => assert(math.abs((expected - actual) /
expected) < 1E-5)
}
+ }
+
+ test("window size") {
+
+ val sqlContext = new SQLContext(sc)
--- End diff --
Good point, all of the other tests in this suite also construct the
SQLContext at the start this way I'll factor it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
