Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47033301
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -592,11 +594,17 @@ class Analyzer(
}
def containsAggregates(exprs: Seq[Expression]): Boolean = {
- exprs.foreach(_.foreach {
- case agg: AggregateExpression => return true
- case _ =>
- })
- false
+ // Collect all Windowed Aggregate Expressions.
+ val blacklist = exprs.flatMap { expr =>
+ expr.collect {
+ case WindowExpression(ae: AggregateExpression, _) => ae
+ }
+ }.toSet
+
+ // Find the first Aggregate Expression that is not Windowed.
+ exprs.exists(_.collectFirst {
--- End diff --
Could `collectFirst` also be replaced by `exists`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
