Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8287#discussion_r47208179
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalFunctions.scala
---
@@ -66,10 +66,44 @@ case class MakeDecimal(child: Expression, precision:
Int, scale: Int) extends Un
* An expression used to wrap the children when promote the precision of
DecimalType to avoid
* promote multiple times.
*/
-case class ChangeDecimalPrecision(child: Expression) extends
UnaryExpression {
+case class PromotePrecision(child: Expression) extends UnaryExpression {
override def dataType: DataType = child.dataType
override def eval(input: InternalRow): Any = child.eval(input)
override def gen(ctx: CodeGenContext): GeneratedExpressionCode =
child.gen(ctx)
override protected def genCode(ctx: CodeGenContext, ev:
GeneratedExpressionCode): String = ""
- override def prettyName: String = "change_decimal_precision"
+ override def prettyName: String = "promote_precision"
+}
+
+/**
+ * Rounds the decimal to given scale and check whether the decimal can fit
in provided precision
+ * or not, returns null if not.
+ */
+case class CheckOverflow(child: Expression, dataType: DecimalType) extends
UnaryExpression {
+
+ override def nullable: Boolean = true
+
+ override def nullSafeEval(input: Any): Any = {
+ val d = input.asInstanceOf[Decimal].clone()
--- End diff --
Why clone here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
