Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10261#discussion_r47314731
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -580,6 +583,12 @@ private[netty] class NettyRpcHandler(
// Create a new message with the socket address of the client as the
sender.
RequestMessage(clientAddr, requestMessage.receiver,
requestMessage.content)
} else {
+ // The remote RpcEnv listens to some port, we should also fire a
RemoteProcessConnected for
+ // the listening address
+ val remoteEnvAddress = requestMessage.senderAddress
+ if (remoteAddresses.putIfAbsent(clientAddr, remoteEnvAddress) ==
null) {
+ dispatcher.postToAll(RemoteProcessConnected(remoteEnvAddress))
--- End diff --
We don't need to concern about multiple network messages with different
addresses since the codes already handle the bad addresses.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
