Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10201#issuecomment-163864668 looks good, though I'm concerned with the replace column which could be breaking behavior change we should document. Also @shivaram I think this shows it's good to be able to detected new/accidentally masked function :) #10171
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org