Github user ankurdave commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9470#discussion_r47396144
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
    @@ -620,6 +608,32 @@ class DataFrame private[sql](
       }
     
       /**
    +   * Returns a new [[DataFrame]] with each partition sorted by the given 
expressions.
    +   *
    +   * This is the same operation as "SORT BY" in SQL (Hive QL).
    +   *
    +   * @group dfops
    +   * @since 1.6.0
    +   */
    +  @scala.annotation.varargs
    +  def sortWithinPartitions(sortCol: String, sortCols: String*): DataFrame 
= {
    +    sortWithinPartitions(sortCol, sortCols : _*)
    --- End diff --
    
    @rxin This causes an infinite loop, which isn't caught by the unit tests 
since DataFrameSuite only tests the `Column*` overload.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to