Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164107825 > I saw your following comment...But I don't get it. That's because we took opposite approaches. Your PR's approach is "if this connection says the sender address is a listening socket, then also consider that address when sending events about the remote process". My PR takes the opposite approach: the address of the remote process is always the address of the socket used to connect, regardless of whether its also listening in another socket. I think my approach is in the end more correct, but requires more code to fix existing code. In my view, `RpcCallContext.senderAddress` should be the address of the socket that sent the message, not the address the remote process is listening on.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org