[GitHub] spark pull request: [SPARK-12324][MLLIB][DOC] Fixes the sidebar in...

[thunterdb]

GitHub user thunterdb opened a pull request:

    https://github.com/apache/spark/pull/10297

    [SPARK-12324][MLLIB][DOC] Fixes the sidebar in the ML documentation

    This fixes the sidebar, using a pure CSS mechanism to hide it when the 
browser's viewport is too narrow.
    Credit goes to the original author @Titan-C (mentioned in the NOTICE).
    
    Note that I am not a CSS expert, so I can only address comments up to some 
extent.
    
    Default view:
    <img width="936" alt="screen shot 2015-12-14 at 12 46 39 pm" 
src="https://cloud.githubusercontent.com/assets/7594753/11793597/6d1d6eda-a261-11e5-836b-6eb2054e9054.png";>
    
    When collapsed manually by the user:
    <img width="1004" alt="screen shot 2015-12-14 at 12 54 02 pm" 
src="https://cloud.githubusercontent.com/assets/7594753/11793669/c991989e-a261-11e5-8bf6-aecf3bdb6319.png";>
    
    
    Disappears when column is too narrow:
    <img width="697" alt="screen shot 2015-12-14 at 12 47 22 pm" 
src="https://cloud.githubusercontent.com/assets/7594753/11793607/7754dbcc-a261-11e5-8b15-e0d074b0e47c.png";>
    
    Can still be opened by the user if necessary:
    <img width="651" alt="screen shot 2015-12-14 at 12 51 15 pm" 
src="https://cloud.githubusercontent.com/assets/7594753/11793612/7bf82968-a261-11e5-9cc3-e827a7a6b2b0.png";>


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thunterdb/spark 12324

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10297
    
----
commit dc8d41b94aa49c31849596ea986368c3bb3c29e3
Author: Timothy Hunter <timhun...@databricks.com>
Date:   2015-12-14T19:39:54Z

    menu

commit 94e82743956bce72f5ca2402be535fced36db24e
Author: Timothy Hunter <timhun...@databricks.com>
Date:   2015-12-14T20:00:50Z

    colors fixed

commit b091b42660ac510ba49ddf0274c779ae1c249b67
Author: Timothy Hunter <timhun...@databricks.com>
Date:   2015-12-14T20:41:28Z

    add the original author to the notice

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org