Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9819#discussion_r47565984
  
    --- Diff: 
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveWindowFunctionQuerySuite.scala
 ---
    @@ -472,7 +475,7 @@ class HiveWindowFunctionQuerySuite extends 
HiveComparisonTest with BeforeAndAfte
           |window w1 as (distribute by p_mfgr sort by p_mfgr, p_name
           |             rows between 2 preceding and 2 following)
         """.stripMargin, reset = false)
    -
    +  */
    --- End diff --
    
    I have added a statistical test case to the ```DataFrameWindowSuite```, 
this however doesn't match the level of thoroughness of the disabled tests. I 
have tried to add these tests verbatim to a separate test suite, but this 
becomes quite verbose and ugly (in style) and I rather not add this. I could 
expand the tests in the ```DataFrameWindowSuite```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to