Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r47593516
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -152,6 +153,17 @@ private[spark] class HttpServer(
}
}
+ private def getAdvertisedOrServerPort: Int = {
+ advertisedPortSetting match {
+ case Some(setting) =>
+ conf.getOption(setting).map(_.toInt).getOrElse(0) match {
+ case x if x > 0 => x
+ case _ => port
+ }
+ case None => port
+ }
+ }
+
/**
* Get the URI of this HTTP server (http://host:port or
https://host:port)
--- End diff --
Should we be more clear here that this is the advertised Uri?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
