Github user markgrover commented on the pull request:

    https://github.com/apache/spark/pull/7739#issuecomment-164877416
  
    Hey Andrew, thanks for your feedback.
    
    > What happens if I specify different versions of some jar on both common 
and executor class path? Which one gets loaded first? What if I pass in 
--common-class-path and set spark.executor.extraClassPath at the same time, is 
it the same?
    
    The semantics are that common classpath is always added before the 
individual driver/executor classpath. I can clarify that in the documentation.
    
    As far as your other point about two versions of the same jar goes, one 
could do that just by using spark.[driver|executor].extraClassPath too and the 
same logic would apply.
    
    I was actually planning on updating this patch this week before the 
holidays roll in so I'd definitely vouch for not closing this. My motivation 
here is that many spark users, want to update both their driver and executor 
classpaths and either forget, miss or find cumbersome to update 2 different 
places for doing so. Common classpath would be one single go-to place for such 
users.
    
    Would you be open to taking another look at this once I update this patch 
this week?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to