Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-165203618
So IIUC stop is only invoked when an exception occured or shutdown hook is
invoked, where both cases it's an task that didn't really finish and
user/system want it to be killed. So I'm not sure if ending in these cases to
have TASK_KILLED is an bad idea.
The main reason I'm proposing not to change this is really I don't think
sleeping in the stop method with a while is a great idea, as it clearly can
block other things going on in the system.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
