Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9027#discussion_r47865499
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala
---
@@ -210,12 +216,18 @@ private[spark] class MesosSchedulerBackend(
}
/**
- * Method called by Mesos to offer resources on slaves. We respond by
asking our active task sets
- * for tasks in order of priority. We fill each node with tasks in a
round-robin manner so that
- * tasks are balanced across the cluster.
+ * Return the usable Mesos offers and corresponding WorkerOffers.
+ *
+ * This method declines Mesos offers that don't meet minimum cpu, memory
or attribute
+ * requirements.
+ *
+ * @param d Mesos SchedulerDriver to decline offers
+ * @param offers Mesos offers to be considered
+ * @return a pair of Mesos offers and corresponding WorkerOffer that can
be used by the
+ * fine-grained scheduler.
*/
- override def resourceOffers(d: SchedulerDriver, offers: JList[Offer]) {
- inClassLoader() {
+ private[spark] def usableWorkerOffers(d: SchedulerDriver,
--- End diff --
I think we've consistently put the function parameters that are longer than
100 in newlines so far, can you move `d: SchedulerDriver` to the next line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
