Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10298#discussion_r47892645
  
    --- Diff: python/pyspark/mllib/feature.py ---
    @@ -174,6 +174,38 @@ def setWithStd(self, withStd):
             self.call("setWithStd", withStd)
             return self
     
    +    @property
    +    @since('2.0.0')
    +    def withStd(self):
    +        """
    +        Returns if the model scales the data to unit standard deviation.
    +        """
    +        return self.call("withStd")
    +
    +    @property
    +    @since('2.0.0')
    +    def withMean(self):
    +        """
    +        Returns if the model centers the data before scaling.
    +        """
    +        return self.call("withMean")
    +
    +    @property
    +    @since('2.0.0')
    +    def std(self):
    +        """
    +        Return the column standard deviation values. Only set if model was 
trained withStd.
    +        """
    +        return self.call("std")
    +
    +    @property
    +    @since('2.0.0')
    +    def mean(self):
    --- End diff --
    
    @holdenk quick question - if `withMean` or `withStd` is `false`, does this 
return `None` or `0.0`? It is worth adding a little test for this case at all?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to