Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10342#discussion_r47939422
  
    --- Diff: core/src/main/scala/org/apache/spark/io/LZ4BlockInputStream.java 
---
    @@ -0,0 +1,259 @@
    +package org.apache.spark.io;
    +
    +/*
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +import java.io.EOFException;
    +import java.io.FilterInputStream;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.util.zip.Checksum;
    +
    +import net.jpountz.lz4.LZ4BlockOutputStream;
    +import net.jpountz.lz4.LZ4Exception;
    +import net.jpountz.lz4.LZ4Factory;
    +import net.jpountz.lz4.LZ4FastDecompressor;
    +import net.jpountz.util.SafeUtils;
    +import net.jpountz.xxhash.StreamingXXHash32;
    +import net.jpountz.xxhash.XXHash32;
    +import net.jpountz.xxhash.XXHashFactory;
    +
    +/**
    + * {@link InputStream} implementation to decode data written with
    + * {@link LZ4BlockOutputStream}. This class is not thread-safe and does not
    + * support {@link #mark(int)}/{@link #reset()}.
    + * @see LZ4BlockOutputStream
    + *
    + * This is based on net.jpountz.lz4.LZ4BlockInputStream
    --- End diff --
    
    Can you comment what is modified? This is otherwise hard to review/maintain 
if lz4 updates.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to