GitHub user sarutak opened a pull request:

    https://github.com/apache/spark/pull/10381

    [SPARK-12424][ML] The implementation of ParamMap#filter is wrong.

    ParamMap#filter uses `mutable.Map#filterKeys`. The return type of 
`filterKey` is collection.Map, not mutable.Map but the result is casted to 
mutable.Map using `asInstanceOf` so we get `ClassCastException`.
    Also, the return type of Map#filterKeys is not Serializable. It's the issue 
of Scala (https://issues.scala-lang.org/browse/SI-6654).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarutak/spark SPARK-12424

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10381
    
----
commit 95e3ff27d9dfd242bce322d6b3b635eb7fea2a8d
Author: Kousuke Saruta <saru...@oss.nttdata.co.jp>
Date:   2015-12-18T15:33:44Z

    Fixed ParamMap#filter to avoid ClassCastException and SI-6654

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to