Github user iyounus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10384#discussion_r48064092
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala 
---
    @@ -31,13 +30,17 @@ import org.apache.spark.sql.DataFrame
      */
     @Since("1.2.0")
     class RegressionMetrics @Since("1.2.0") (
    -    predictionAndObservations: RDD[(Double, Double)]) extends Logging {
    +    predictionAndObservations: RDD[(Double, Double)], isUnbiased: Boolean 
= true)
    --- End diff --
    
    I will double check this. I've seen this being called biased. The problem 
is that this special case is rarely discussed in literature so the 
documentation is scarce.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to