Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48127272
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,11 +28,13 @@ import org.apache.spark.sql.catalyst.plans.logical._
import org.apache.spark.sql.catalyst.rules._
import org.apache.spark.sql.types._
-abstract class Optimizer extends RuleExecutor[LogicalPlan]
-
-object DefaultOptimizer extends Optimizer {
- val batches =
- // SubQueries are only needed for analysis and can be removed before
execution.
+/**
+ * Abstract class all optimizers should inherit of, contains the standard
batches (extending
+ * Optimizers can override this.
+ */
+abstract class Optimizer extends RuleExecutor[LogicalPlan] {
+ def batches: Seq[Batch] =
+ // SubQueries are only needed for analysis and can be removed before
execution.
--- End diff --
add 2 space before this comment, to align it to the "Remove SubQueries"
batch it's talking about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
