Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48200071
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,21 +23,28 @@ import org.apache.spark.Logging
import org.apache.spark.mllib.linalg.Vectors
import org.apache.spark.mllib.stat.{MultivariateStatisticalSummary,
MultivariateOnlineSummarizer}
import org.apache.spark.sql.DataFrame
-
/**
* Evaluator for regression.
*
- * @param predictionAndObservations an RDD of (prediction, observation)
pairs.
+ * @param predictionAndObservations an RDD of (prediction, observation)
pairs,
+ * @param isUnbiased true if intercept is included in linear regression
model
*/
@Since("1.2.0")
class RegressionMetrics @Since("1.2.0") (
- predictionAndObservations: RDD[(Double, Double)]) extends Logging {
+ predictionAndObservations: RDD[(Double, Double)], isUnbiased: Boolean)
+ extends Logging {
+ /**
--- End diff --
Need a space before this, and the scaladoc body lines are indented too much
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
